Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update syntax blocks for JSON, Map, Math #4569

Merged
merged 2 commits into from
Apr 29, 2021

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Apr 28, 2021

@Elchi3 Elchi3 requested a review from a team as a code owner April 28, 2021 19:20
@Elchi3 Elchi3 requested review from wbamberg and removed request for a team April 28, 2021 19:20
@github-actions
Copy link
Contributor

github-actions bot commented Apr 28, 2021

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Math/hypot
Title: Math.hypot()
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Math/imul
Title: Math.imul()
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Math/max
Title: Math.max()
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Math/min
Title: Math.min()
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Math/fround
Title: Math.fround()
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Map/entries
Title: Map.prototype.entries()
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Map/has
Title: Map.prototype.has()
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Map/delete
Title: Map.prototype.delete()
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Map/values
Title: Map.prototype.values()
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Map/set
Title: Map.prototype.set()
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Map/Map
Title: Map() constructor
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Map/clear
Title: Map.prototype.clear()
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Map/keys
Title: Map.prototype.keys()
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Map/forEach
Title: Map.prototype.forEach()
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Map/get
Title: Map.prototype.get()
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/JSON/stringify
Title: JSON.stringify()
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/JSON/parse
Title: JSON.parse()
on GitHub

(this comment was updated 2021-04-29 07:07:45.398780)

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look fine, except some have semicolons and some don't. Is there a reason here?

The meta-docs also are inconsistent about this: https://developer.mozilla.org/en-US/docs/MDN/Structures/Syntax_sections.

I think I would prefer no semicolons.

Co-authored-by: Michael[tm] Smith <[email protected]>
@sideshowbarker sideshowbarker merged commit 7cc89d1 into mdn:main Apr 29, 2021
@Elchi3 Elchi3 deleted the syntaxes-json-map-math branch April 29, 2021 07:53
@wbamberg wbamberg mentioned this pull request Apr 11, 2022
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants