Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagemacro fix4 #4693

Merged
merged 6 commits into from
May 4, 2021
Merged

Pagemacro fix4 #4693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cf5cb9c
Link to Web console helpers rather than include
hamishwillee May 4, 2021
c06bdb0
Fix compatibility table in Window.ondeviceorientation
hamishwillee May 4, 2021
fd53b0c
Markup class attribute to discuss
hamishwillee May 4, 2021
45092c1
duplicate the SVG data type
hamishwillee May 4, 2021
9b43abe
Remove the import. Already linked
hamishwillee May 4, 2021
52ec35d
Fix fixable flaws in cursor
hamishwillee May 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions files/en-us/tools/web_console/helpers/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@
---
<p>{{ToolsSidebar}}</p>

<h2 id="The_commands">The commands</h2>

<p>The JavaScript command line provided by the Web Console offers a few built-in helper functions that make certain tasks easier.</p>

<dl>
Expand Down
5 changes: 3 additions & 2 deletions files/en-us/tools/web_console/the_command_line_interpreter/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ <h2 id="Execution_history">Execution history</h2>
<li>In multi-line mode, use the  <strong>⋀</strong> and <strong>⋁</strong> icons in the editing panel's toolbar.</li>
</ul>

<p>The expression history is persisted across sessions. To clear the history, use the <code>clearHistory()</code> <a href="/en-US/docs/Tools/Web_Console/The_command_line_interpreter#helper_commands">helper function</a>.</p>
<p>The expression history is persisted across sessions. To clear the history, use the <code>clearHistory()</code> <a href="#helper_commands">helper function</a>.</p>

<p>You can initiate a reverse search through the expression history, much like you can in bash on Linux and Mac or PowerShell on Windows. On Windows and Linux press <kbd>F9</kbd>. On Mac press <kbd>Ctrl</kbd>+<kbd>R</kbd> (<strong>note:</strong> not <kbd>Cmd</kbd>+<kbd>R</kbd>!) to initiate the reverse search.</p>

Expand All @@ -128,4 +128,5 @@ <h2 id="Working_with_iframes">Working with iframes</h2>

<h2 id="Helper_commands">Helper commands</h2>

<p>{{ page("en-US/docs/Tools/Web_Console/Helpers", "The commands") }}</p>
<p>The JavaScript command line provided by the Web Console offers a few built-in helper functions that make certain tasks easier.
For more information see <a href="/en-US/docs/Tools/Web_Console/Helpers">Web Console Helpers</a>.</p>
14 changes: 7 additions & 7 deletions files/en-us/web/api/window/ondeviceorientation/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@
title: Window.ondeviceorientation
slug: Web/API/Window/ondeviceorientation
tags:
- API
- Device Orientation
- Mobile
- Orientation
- Property
- API
- Device Orientation
- Mobile
- Orientation
- Property
---
<p>{{ ApiRef() }}</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is giving me MacroPagesError for

  • globalcrypto (likely meant to point to /en-US/docs/Web/API/Crypto )
  • speechsynthesisgetter ( /en-US/docs/Web/API/SpeechSynthesis/getVoices maybe?)
  • windowmodal (Lacking the context. /en-US/docs/Web/API/Window/prompt ?)
  • onerroreventhandlerforwindow (Likely /en-US/docs/Web/API/GlobalEventHandlers/onerror )
  • chromewindow (the browser or the part of a web browser?)

Do you want to address them as part of this PR?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to address them as part of this PR?

Thanks for spotting these. I'm pretty much fixing the easy flaws along the way, but mostly this is just about PageMacro. Upshot "No".

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PS These aren't in the page - they are in the sidebar. I do think we should look at them, but not in this.


Expand Down Expand Up @@ -42,13 +42,13 @@ <h2 id="Specifications">Specifications</h2>

<h2 id="Browser_compatibility">Browser compatibility</h2>

<p>{{ page("/en-US/docs/Web/API/DeviceOrientationEvent","Browser_compatibility") }}</p>
<p>{{Compat("api.Window.ondeviceorientation")}}</p>

<h2 id="See_also">See also</h2>

<ul>
<li>{{ event("deviceorientation") }}</li>
<li>{{ domxref("DeviceOrientationEvent") }}</li>
<li><a href="/en-US/docs/Detecting_device_orientation"
<li><a href="/en-US/docs/Web/Events/Detecting_device_orientation"
title="Detecting device orientation">Detecting device orientation</a></li>
</ul>
5 changes: 2 additions & 3 deletions files/en-us/web/svg/attribute/class/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
- SVG
- SVG Attribute
---
<p>« <a href="/en-US/docs/SVG/Attribute">SVG Attribute reference home</a></p>
<p>« <a href="/en-US/docs/Web/SVG/Attribute">SVG Attribute reference home</a></p>

<p>Assigns a class name or set of class names to an element. You may assign the same class name or names to any number of elements, however, multiple class names must be separated by whitespace characters.</p>

Expand All @@ -29,7 +29,7 @@ <h2 id="Usage_context">Usage context</h2>
</tr>
<tr>
<th scope="row">Value</th>
<td><a href="/en-US/docs/SVG/Content_type#List-of-Ts">&lt;list-of-class-names&gt;</a></td>
<td><a href="/en-US/docs/Web/SVG/Content_type#list-of-ts">&lt;list-of-class-names&gt;</a></td>
</tr>
<tr>
<th scope="row">Animatable</th>
Expand All @@ -42,7 +42,6 @@ <h2 id="Usage_context">Usage context</h2>
</tbody>
</table>

<p>{{ page("/en/SVG/Content_type","List-of-Ts") }}</p>
hamishwillee marked this conversation as resolved.
Show resolved Hide resolved

<h2 id="Example">Example</h2>

Expand Down
11 changes: 5 additions & 6 deletions files/en-us/web/svg/attribute/cursor/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@
- SVG
- SVG Attribute
---
<p>« <a href="/en-US/docs/SVG/Attribute">SVG Attribute reference home</a></p>
<p>« <a href="/en-US/docs/Web/SVG/Attribute">SVG Attribute reference home</a></p>

<p>The <code>cursor</code> attribute specifies the mouse cursor displayed when the mouse pointer is over an element.</p>

<p>This attribute behaves exactly like the {{ cssxref("cursor","CSS cursor") }} property except that if the browser supports the {{ SVGElement("cursor") }} element, you should be able to use it with the <a href="/en-US/docs/SVG/Content_type#FuncIRI">&lt;funciri&gt;</a> notation.</p>
<p>This attribute behaves exactly like the {{ cssxref("cursor","CSS cursor") }} property except that if the browser supports the {{ SVGElement("cursor") }} element, you should be able to use it with the <a href="/en-US/docs/Web/SVG/Content_type#funciri">&lt;funciri&gt;</a> notation.</p>

<p>As a presentation attribute, it also can be used as a property directly inside a CSS stylesheet, see {{ cssxref("cursor","CSS cursor") }} for further information.</p>

Expand All @@ -23,7 +23,7 @@ <h2 id="Usage_context">Usage context</h2>
</tr>
<tr>
<th scope="row">Value</th>
<td>[[<a href="/en-US/docs/SVG/Content_type#FuncIRI">&lt;funciri&gt;</a>,]* [ <strong>auto</strong> | crosshair | default | pointer | move | e-resize | ne-resize | nw-resize | n-resize | se-resize | sw-resize | s-resize | w-resize| text | wait | help ]] | inherit</td>
<td>[[<a href="/en-US/docs/Web/SVG/Content_type#funciri">&lt;funciri&gt;</a>,]* [ <strong>auto</strong> | crosshair | default | pointer | move | e-resize | ne-resize | nw-resize | n-resize | se-resize | sw-resize | s-resize | w-resize| text | wait | help ]] | inherit</td>
</tr>
<tr>
<th scope="row">Animatable</th>
Expand All @@ -36,15 +36,14 @@ <h2 id="Usage_context">Usage context</h2>
</tbody>
</table>

<p>{{ page("/en/SVG/Content_type","FuncIRI") }}</p>
hamishwillee marked this conversation as resolved.
Show resolved Hide resolved

<h2 id="Elements">Elements</h2>

<p>The following elements can use the <code>cursor</code> attribute</p>

<ul>
<li><a href="/en-US/docs/SVG/Element#Container_elements">Container elements</a> »</li>
<li><a href="/en-US/docs/SVG/Element#Graphics_elements">Graphics elements</a> »</li>
<li><a href="/en-US/docs/Web/SVG/Element#container_elements">Container elements</a> »</li>
<li><a href="/en-US/docs/Web/SVG/Element#graphics_elements">Graphics elements</a> »</li>
</ul>

<h2 id="Browser_compatibility">Browser compatibility</h2>
Expand Down