Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note on where to use secure context banners #7655

Merged
merged 2 commits into from
Aug 7, 2021

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Aug 6, 2021

As discussed in #7070 (comment)

@Elchi3 Elchi3 requested a review from a team as a code owner August 6, 2021 10:04
@Elchi3 Elchi3 requested review from Rumyra and removed request for a team August 6, 2021 10:04
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2021

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/MDN/Structures/Macros/Commonly-used_macros
Title: Commonly-used macros
on GitHub

No new external URLs

(this comment was updated 2021-08-06 11:23:09.402285)

Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me, I will wait before merging to let other review or voice their opinions. (If silent, I'll merge tomorrow and we can always change again later if needed)

@teoli2003 teoli2003 merged commit bbd7387 into mdn:main Aug 7, 2021
@Elchi3 Elchi3 deleted the secure-context-usage branch August 7, 2021 09:04
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants