Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update (most) tables to be md compatible in Web/HTTP #7815

Merged
merged 2 commits into from
Aug 12, 2021

Conversation

teoli2003
Copy link
Contributor

@teoli2003 teoli2003 commented Aug 11, 2021

This makes most tables in Web/HTTP compatible with the Markdown conversion script.

  • I removed all the standard-table classes.
  • Some are just adapted (updating the <th>, removing the scope attributes, removing the rowspan, often by repeating the info.
  • Some tables have been broken into sub-tables, between headings, to remove the first column.
  • A couple were old-style specification tables that I converted to the new style, compatible with md.

Properties tables are not dealt with here (I will keep them)

After this, there are still two documents with tables to convert, but they will be in a separate PR as they are more complex.

For bookkeeping purposes: this is part of #7536.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2021

Preview URLs

Flaws

Note! 6 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/HTTP/Headers/User-Agent/Firefox
Title: Firefox user agent string reference
on GitHub
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Setting_HTTP_request_headers
    • Can't resolve /en-US/docs/Browser_Detection_and_Cross_Browser_Support

External URLs

URL: /en-US/docs/Web/HTTP/Redirections
Title: Redirections in HTTP
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTTP/Headers/Referrer-Policy
Title: Referrer-Policy
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTTP/Headers/Want-Digest
Title: Want-Digest
on GitHub


URL: /en-US/docs/Web/HTTP/Headers/Digest
Title: Digest
on GitHub


URL: /en-US/docs/Web/HTTP/Headers/User-Agent/Firefox
Title: Firefox user agent string reference
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTTP/CSP/Errors/CSPViolation
Title: Content Security Policy: The page’s settings blocked the loading of a resource: xyz
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTTP/Basics_of_HTTP/MIME_types/Common_types
Title: Common MIME types
on GitHub

(this comment was updated 2021-08-12 09:30:21.027603)

@teoli2003 teoli2003 marked this pull request as ready for review August 11, 2021 08:33
@teoli2003 teoli2003 requested a review from a team as a code owner August 11, 2021 08:33
@teoli2003 teoli2003 requested review from mirunacurtean and wbamberg and removed request for a team and mirunacurtean August 11, 2021 08:33
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just a request on text/javascript.

@@ -162,13 +162,7 @@
<td><code>.js</code></td>
<td>JavaScript</td>
<td>
<p><code>text/javascript</code>, per the following specifications:</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, this was added here because we had several issues changing it back and forth. See #4077. Can we leave this here somehow?

@Elchi3 Elchi3 merged commit 2350953 into mdn:main Aug 12, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants