Add text-wrap and white-space-collapse, and update white-space #664
Conversation
|
@teoli2003 Hello! Please could you have a look at this one? |
github-actions
bot
added
the
idle
|
@bsmth can you review this one please mate? |
|
I can indeed, I'll take a look tomorrow if that's okay |
That's perfect, thanks! |
github-actions
bot
removed
the
idle
| @@ -1,2 +1,2 @@ | |||
| /node_modules/ | |||
| .DS_Store | |||
| .DS_Store | |||
There was a problem hiding this comment.
🤔 I thought I added this here: 4f74b57 not sure what the difference is
There was a problem hiding this comment.
I added it too, in this PR, so it ended up creating a merge conflict. That's why it looks a little odd.
There was a problem hiding this comment.
Looks good, @chrisdavidmills - one comment about the missing prop you mentioned, but ready to go after that 👍🏻
Co-authored-by: Brian Thomas Smith <[email protected]>
Cool, thanks for the review @bsmth . I've added |
|
@bsmth ooop, I can't merge in this repo. Can you merge it? Ta. |
Description
Chrome 114 adds the
text-wrapandwhite-space-collapseCSS properties, and updates thewhite-spaceproperty with new behavior — as well as taking its usual keywords, it can now act as a shorthand property fortext-wrapandwhite-space-collapse. These items are specified in CSS Text Level 4.This PR adds those items to the data. I also took this opportunity to add
.DS_Storefiles to the.gitignorefile. As a mac user, that was getting on my nerves ;'-)Note - there is another related property,
white-space-trim, which is specced as being included in thewhite-spaceshorthand value, but this is not supported yet so I have not added it. Let me know if you think I should add it.Motivation
Additional details
My research document provides additional details about this overall project and its required changes.
Related issues and pull requests