Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async generator examples #1784

Merged
merged 5 commits into from
Jul 14, 2021
Merged

Async generator examples #1784

merged 5 commits into from
Jul 14, 2021

Conversation

Rumyra
Copy link
Contributor

@Rumyra Rumyra commented Mar 23, 2021

Interactive examples for async generator docs; see mdn/content#2861

Both statement and operator added.

NB there is an existing statement-async-function-asterisk.js which is a great example, but a great in-page example. I have added statement-asyncfunctionasterisk.js as the interactive example. I have not removed the former in case it's being used somewhere I am unaware of 👍

Copy link
Contributor

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eek, sorry to be slow reviewing this @Rumyra .

These examples look great, but you need to update the metadata to tell the site builder about these examples, or they won't get built: https://github.com/mdn/interactive-examples/blob/master/CONTRIBUTING-JavaScript.md#updating-the-metadata.

NB there is an existing statement-async-function-asterisk.js which is a great example, but a great in-page example. I have added statement-asyncfunctionasterisk.js as the interactive example. I have not removed the former in case it's being used somewhere I am unaware of 👍

I think it would be better to replace that example with the new one. I can't imagine an example in this repo could be being used as anything other than an interactive example.

@Rumyra
Copy link
Contributor Author

Rumyra commented Jul 14, 2021

Okey dokey - I have tidied this up a bit - made sure the metadata is up to date and copied over the existing example statement-async-function-asterisk.js and renamed the other because 👍

@Rumyra Rumyra requested a review from wbamberg July 14, 2021 11:39
Copy link
Contributor

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Rumyra , these are super clean examples!

@wbamberg wbamberg merged commit e63d1b2 into mdn:master Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants