Skip to content
This repository has been archived by the owner on Sep 7, 2021. It is now read-only.

Lint pages against recipes #320

Merged
merged 22 commits into from
Mar 2, 2020
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 69 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
"gray-matter": "4.0.2",
"hast-util-find-and-replace": "^2.0.0",
"hast-util-has-property": "^1.0.3",
"hast-util-select": "^3.0.1",
"hast-util-to-text": "^1.0.1",
"js-yaml": "3.13.1",
"jsdom": "16.2.0",
Expand Down
11 changes: 10 additions & 1 deletion scripts/scraper-ng/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ const limiter = require("./rate-limiter");
const mdnUrl = require("./mdn-url");
const summaryReporter = require("./vfile-reporter-summary");
const toVFile = require("./url-to-vfile");
const VMessage = require("vfile-message");

const examplePage =
"https://developer.mozilla.org/en-US/docs/Web/HTML/Element/div";
Expand Down Expand Up @@ -65,7 +66,15 @@ async function run() {
const file = await toVFile(url);
const hasFileErrors = file.messages.length > 0;
if (!hasFileErrors) {
await processor.process(file);
try {
await processor.process(file);
} catch (err) {
// If a VMessage gets thrown, then this should not interrupt subsequent
// files, but other errors should break everything
if (!(err instanceof VMessage)) {
throw err;
}
}
}
return file;
});
Expand Down
5 changes: 2 additions & 3 deletions scripts/scraper-ng/preset.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
const allowedMacros = ["Compat"];
const requiredMacros = ["Compat"];

module.exports = {
settings: {},
Expand All @@ -11,7 +10,7 @@ module.exports = {
// For rules that don't need settings of any kind:
// [require('./rules/rule-name')]
[require("./rules/file-require-recipe")],
[require("./rules/html-require-macros"), ["error", requiredMacros]],
[require("./rules/html-warn-macros"), allowedMacros]
[require("./rules/html-warn-macros"), allowedMacros],
[require("./rules/html-require-recipe-ingredients")]
]
};
2 changes: 1 addition & 1 deletion scripts/scraper-ng/rules/file-require-recipe.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ function msg(file, text, ruleId, note) {
message.fatal = true;
message.ruleId = ruleId;
message.note = note;
return message;
throw message;
}

module.exports = requireRecipe;
32 changes: 0 additions & 32 deletions scripts/scraper-ng/rules/html-require-macros.js

This file was deleted.

Loading