-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syntax highlighting breaks Formal Syntax for CSSSyntax #2963
Comments
So the correct fix is to turn that into: -<pre class="brush: css notranslate">{{CSSSyntax}}</pre>
+{{CSSSyntax}} ? |
If it's a simple matter of a bunch of search-and-replace (78 to be exact), let's just do that in the mdn/content and never have to think about it :) |
Note-to-Florian; you can do it to the translated-content repo too now :) |
Tried Peter's suggested change locally and it works. Unfortunately, that also removes the code layout. Therefore it still needs to be wrapped in a Sebastian |
mdn/content#3163 is meant to fix this issue. @peterbe There are far more pages affected (exactly 536) because most of them embed the macro using its name in lowercase. Sebastian |
@fiji-flo Took care of it. He timed a mass-edit of the content with an edit of the KS macro. So now, the KS macro is responsible for doing its own I think we can close this once we're certain it made it to prod as expected. At the time of writing, it's about 1h until the Prod build builds and also at the time of writing, GitHub is having problems with Actions. |
#3244 resolves this. Thank you @SebastianZ, weird timing, we fixed it the same day. |
Yeah, what a coincidence! But don't worry! It's great this is got fixed now! Thank you! Sebastian |
Our syntax highlighting breaks the CSSSyntax macro. It strips the links and explanations. Easiest fix would be fixing the content as this is not highlighted anyhow.
The text was updated successfully, but these errors were encountered: