Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Visibility: Link target doesn't exist #6641

Closed
estelle opened this issue Jun 28, 2022 · 6 comments · Fixed by mdn/data#588
Closed

CSS Visibility: Link target doesn't exist #6641

estelle opened this issue Jun 28, 2022 · 6 comments · Fixed by mdn/data#588
Labels
needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened.

Comments

@estelle
Copy link
Member

estelle commented Jun 28, 2022

MDN URL

https://developer.mozilla.org/en-US/docs/Web/CSS/visibility

What specific section or headline is this issue about?

animation type

What information was incorrect, unhelpful, or incomplete?

In the formal definition, the animation type value is a link to a target not addressed in the document: https://developer.mozilla.org/en-US/docs/Web/CSS/visibility#Interpolation

What did you expect to see?

a definition of the animation type somewhere

Do you have any supporting links, references, or citations?

https://www.w3.org/TR/css-display-3/#visibility

animation type is discrete.

Do you have anything more you want to share?

No response

MDN metadata

Page report details
@github-actions github-actions bot added Content:CSS needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Jun 28, 2022
@sideshowbarker sideshowbarker removed the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Jun 29, 2022
@wbamberg
Copy link
Collaborator

The link target does exist: https://developer.mozilla.org/en-US/docs/Web/CSS/visibility#Interpolation ... but following the link in https://developer.mozilla.org/en-US/docs/Web/CSS/visibility#formal_definition doesn't take you there. Is this a Yari thing?

@teoli2003
Copy link
Contributor

I think the following is happening:

  • all our anchors (link targets) are lowercase. When converting Markdown to HTML, Yari converts link targets to lowercase. (We still try to fix them in the source in mdn/content for cleanness reasons, but this is not really needed).
  • Nevertheless, in this case, the link starts with a capital: it doesn't work
  • The reason why Yari didn't fix it is that this HTML is generated by a macro, and not magically fixed by Yari.

So I think it is a bug in the macro.

@wbamberg
Copy link
Collaborator

Ah, you are right!

@wbamberg wbamberg transferred this issue from mdn/content Jun 30, 2022
@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Jun 30, 2022
@wbamberg
Copy link
Collaborator

@teoli2003
Copy link
Contributor

Oh yes, you nailed it.

@teoli2003
Copy link
Contributor

I think we can close this.

@estelle estelle closed this as completed Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants