enhance(l10n): localize en-US link title #11011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
flaw-system
caugner
commented
Apr 26, 2024
libs/l10n/l10n.ts
Outdated
|
|
||
| export const ONLY_AVAILABLE_IN_ENGLISH = localString({ | ||
| "en-US": "This page is currently only available in English.", | ||
| es: "Esta página está disponible solo en inglés.", |
There was a problem hiding this comment.
@mdn/yari-content-es Can you please check this translation? 🙏
There was a problem hiding this comment.
It looks good to me 👍 cc @Graywolf9
libs/l10n/l10n.ts
Outdated
| export const ONLY_AVAILABLE_IN_ENGLISH = localString({ | ||
| "en-US": "This page is currently only available in English.", | ||
| es: "Esta página está disponible solo en inglés.", | ||
| fr: "Cette page est actuellement disponible uniquement en anglais.", |
There was a problem hiding this comment.
@mdn/yari-content-fr Can you please check this translation? 🙏
| "en-US": "This page is currently only available in English.", | ||
| es: "Esta página está disponible solo en inglés.", | ||
| fr: "Cette page est actuellement disponible uniquement en anglais.", | ||
| ja: "このページは現在、英語のみで利用可能です。", |
There was a problem hiding this comment.
@mdn/yari-content-ja Can you please check this translation? 🙏
libs/l10n/l10n.ts
Outdated
| fr: "Cette page est actuellement disponible uniquement en anglais.", | ||
| ja: "このページは現在、英語のみで利用可能です。", | ||
| ko: "이 페이지는 현재 영어로만 제공됩니다.", | ||
| "pt-BR": "Esta página está disponível apenas em inglês no momento.", |
There was a problem hiding this comment.
@mdn/yari-content-pt-br Can you please check this translation? 🙏
leon-win
reviewed
Apr 26, 2024
Co-authored-by: Leonid Vinogradov <[email protected]>
JuanVqz
approved these changes
Apr 26, 2024
leon-win
approved these changes
Apr 26, 2024
LeoMcA
requested changes
Apr 29, 2024
libs/l10n/l10n.ts
Outdated
Comment on lines
1
to
11
| type Locale = | ||
| | "en-US" | ||
| | "es" | ||
| | "fr" | ||
| | "ja" | ||
| | "ko" | ||
| | "pt-BR" | ||
| | "ru" | ||
| | "zh-CN" | ||
| | "zh-TW"; | ||
| type TranslatedLocale = Exclude<Locale, "en-US">; |
There was a problem hiding this comment.
nit: I imagine these will be useful to use elsewhere, perhaps we export them already to save the code change later?
kumascript/src/api/web.ts
Outdated
| @@ -5,10 +5,13 @@ import * as util from "./util.js"; | |||
|
|
|||
| import { CONTENT_ROOT } from "../../../libs/env/index.js"; | |||
| import { KumaThis } from "../environment.js"; | |||
| import { DEFAULT_LOCALE } from "../../../libs/constants/index.js"; | |||
There was a problem hiding this comment.
Suggested change
| import { DEFAULT_LOCALE } from "../../../libs/constants/index.js"; |
|
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
bot
added
merge conflicts 🚧
caugner
commented
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Links in other locales that point to the English locale have a title saying "Currently only available in English (US)", but this is not translated in the locales, and so it cannot be understood by users who don't understand English.
Solution
Translate the title in all locales.
Screenshots
Before
After
How did you test this change?
Ran
yarn devand checked http://localhost:3000/es/docs/Web/API#a locally.Approvals