Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(macros/LearnSidebar): add Japanese translations for JavaScript #11988

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

gurezo
Copy link
Contributor

@gurezo gurezo commented Oct 19, 2024

Summary

@hmatrjp @potappo , @mdn-yari-ja

please review for this pull request

Problem

  • There is no Japanese translation yet

English pages

Japanese pages

before after
スクリーンショット 2024-10-19 13 17 36 スクリーンショット 2024-10-19 13 17 12

Solution

translate japanese for LearnSidebar.ejs

NOTICE

@mdn/core-dev

Please merge once mdn-yari-ja is approved.

Before

  • There is no Japanese translation yet

After

  • tranlate japanese for LearnSidebar.ejs

@gurezo gurezo requested a review from a team as a code owner October 19, 2024 04:38
@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Oct 19, 2024
Copy link
Contributor

@potappo potappo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gurezo , translations are good.

@caugner caugner merged commit 2aa510c into mdn:main Oct 21, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macros tracking issues related to kumascript macros
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants