Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check out mdn/content after 'npm pack' #3188

Merged
merged 2 commits into from
Mar 11, 2021
Merged

check out mdn/content after 'npm pack' #3188

merged 2 commits into from
Mar 11, 2021

Conversation

peterbe
Copy link
Contributor

@peterbe peterbe commented Mar 10, 2021

Fixes #3044

@peterbe peterbe requested a review from nschonni March 10, 2021 20:23
nschonni
nschonni approved these changes Mar 10, 2021
View reviewed changes
Copy link
Collaborator

@nschonni nschonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, the alternative would be to set a path on the yari cloning so they are side-by-side instead of nested

@peterbe peterbe merged commit ddff93b into mdn:main Mar 11, 2021
@peterbe peterbe deleted the 3044-check-out-mdncontent-after-npm-pack branch March 11, 2021 01:43
This was referenced Mar 11, 2021
Merged
Closed
Merged
peterbe added a commit to peterbe/yari that referenced this pull request Jun 1, 2021
@peterbe
check out mdn/content after 'npm pack' (mdn#3188)
2721a9e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nschonni nschonni nschonni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

We should CI test running yari as mdn/content does
2 participants
@peterbe @nschonni