Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(document-extractor): split h4 sections #4609

Closed
wants to merge 51 commits into from
Closed

fix(document-extractor): split h4 sections #4609

wants to merge 51 commits into from

Commits on Aug 2, 2021

  1. Add one more short circuit AND now that we split by h4 tags as well

    @tannerdolby
    tannerdolby committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    8422ac5 View commit details
    Browse the repository at this point in the history

  2. Add logic to document-extractor.js to split section by h2, h3 OR h4

    @tannerdolby
    tannerdolby committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    45777ee View commit details
    Browse the repository at this point in the history

  3. Introduce isH4 and DisplayH4 to spec-section

    @tannerdolby
    tannerdolby committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    7dfc273 View commit details
    Browse the repository at this point in the history

  4. Introduce isH4 and DisplayH4 to lazy-bcd-table

    @tannerdolby
    tannerdolby committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    3f97e7b View commit details
    Browse the repository at this point in the history

  5. Add logic to conditionally render DisplayH4 component

    @tannerdolby
    tannerdolby committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    6dbbb3d View commit details
    Browse the repository at this point in the history

  6. Create DisplayH4 functional component in utils.tsx

    @tannerdolby
    tannerdolby committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    762ffad View commit details
    Browse the repository at this point in the history

  7. Add h4 selector to make sure they receive the same styles as other di… 

    …rect heading links
    @tannerdolby
    tannerdolby committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    bb79fd9 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2021

  1. Refactor child.tagName conditional check

    @tannerdolby
    tannerdolby committed Aug 3, 2021
    Configuration menu
    Copy the full SHA
    530e09f View commit details
    Browse the repository at this point in the history

  2. Use a set for the tagNames instead

    @tannerdolby
    tannerdolby committed Aug 3, 2021
    Configuration menu
    Copy the full SHA
    e192ecd View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2021

  1. Condense each DisplayH* function into a single DisplayHeading component

    @tannerdolby
    tannerdolby committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    f407799 View commit details
    Browse the repository at this point in the history

  2. Render a single DisplayHeading component based on its level

    @tannerdolby
    tannerdolby committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    2135fc3 View commit details
    Browse the repository at this point in the history

  3. Replace DisplayH2,H3,H4 component calls with a single DisplayHeading

    @tannerdolby
    tannerdolby committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    745b975 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' of github.com:mdn/yari into 4370-split-section-by-h4

    @tannerdolby
    tannerdolby committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    51fb4e0 View commit details
    Browse the repository at this point in the history

  5. Comment out flaws.push for excess <h4> tags not at root-level

    @tannerdolby
    tannerdolby committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    c1f4cdf View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2021

  1. Merge branch 'main' of github.com:mdn/yari into 4370-split-section-by-h4

    @tannerdolby
    tannerdolby committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    de93799 View commit details
    Browse the repository at this point in the history

  2. Create template for test fixture

    @tannerdolby
    tannerdolby committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    c8c0168 View commit details
    Browse the repository at this point in the history

  3. Add jest tests

    @tannerdolby
    tannerdolby committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    f0d5dd1 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2021

  1. Merge branch 'main' of github.com:mdn/yari into 4370-split-section-by-h4

    @tannerdolby
    tannerdolby committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    0054977 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2021

  1. Merge branch 'main' of github.com:mdn/yari into 4370-split-section-by-h4

    @tannerdolby
    tannerdolby committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    a754410 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2022

  1. Merge branch 'main' into 4370-split-section-by-h4

    @tannerdolby
    tannerdolby authored May 14, 2022
    Configuration menu
    Copy the full SHA
    a079000 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2022

  1. Merge branch 'main' of github.com:mdn/yari into 4370-split-section-by… 

    …-h4 and fix merge conflicts
    @tannerdolby
    tannerdolby committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    bd35828 View commit details
    Browse the repository at this point in the history

  2. Remove unused 'DisplayHeading' reference for now

    @tannerdolby
    tannerdolby committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    7306e90 View commit details
    Browse the repository at this point in the history

  3. Accept incoming changes from merge in spec-section.tsx

    @tannerdolby
    tannerdolby committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    436fbf2 View commit details
    Browse the repository at this point in the history

  4. Replace Set.has() with RegExp.test() for performance

    @tannerdolby
    tannerdolby committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    e29a4c9 View commit details
    Browse the repository at this point in the history

  5. Remove unused DisplayH2/H3 references

    @tannerdolby
    tannerdolby committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    044a454 View commit details
    Browse the repository at this point in the history

  6. Use the DisplayHeading component

    @tannerdolby
    tannerdolby committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    986af03 View commit details
    Browse the repository at this point in the history

  7. Access isH4 and isH3 from the section

    @tannerdolby
    tannerdolby committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    437eba8 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2022

  1. Merge branch 'main' into 4370-split-section-by-h4

    Schalk Neethling authored Jun 25, 2022
    Configuration menu
    Copy the full SHA
    d0504d6 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2022

  1. Merge branch 'main' of github.com:mdn/yari into 4370-split-section-by-h4

    @tannerdolby
    tannerdolby committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    3f7752b View commit details
    Browse the repository at this point in the history

  2. Merge branch '4370-split-section-by-h4' of github.com:tannerdolby/yar… 

    …i into 4370-split-section-by-h4
    @tannerdolby
    tannerdolby committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    34555a5 View commit details
    Browse the repository at this point in the history

  3. Refactor section splitting to reduce duplication

    @tannerdolby
    tannerdolby committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    0561206 View commit details
    Browse the repository at this point in the history

  4. Add missing encoding parameter to fs.readFileSync

    @tannerdolby
    tannerdolby committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    f249a3d View commit details
    Browse the repository at this point in the history

  5. Add missing isH4 property to Section types

    @tannerdolby
    tannerdolby committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    73476be View commit details
    Browse the repository at this point in the history

  6. Add isH4 to the ProseSection value to match updated type definition

    @tannerdolby
    tannerdolby committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    a294686 View commit details
    Browse the repository at this point in the history

  7. Remove .html() after extracting Cheerio element to variable

    @tannerdolby
    tannerdolby committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    032b950 View commit details
    Browse the repository at this point in the history

  8. Experimenting with link matching for section splitting tests

    @tannerdolby
    tannerdolby committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    ccd7ffb View commit details
    Browse the repository at this point in the history

  9. Debugging getting the innerHTML from a specific h2/h3/h4 element

    @tannerdolby
    tannerdolby committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    a4efc65 View commit details
    Browse the repository at this point in the history

  10. Add closure function to reduce duplication in heading extraction

    @tannerdolby
    tannerdolby committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    0a051fc View commit details
    Browse the repository at this point in the history

  11. Remove stale function definition for extractHeadings

    @tannerdolby
    tannerdolby committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    08425eb View commit details
    Browse the repository at this point in the history

  12. Debugging section splitting tests

    @tannerdolby
    tannerdolby committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    375e6cc View commit details
    Browse the repository at this point in the history

  13. Testing section splitting

    @tannerdolby
    tannerdolby committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    c9af789 View commit details
    Browse the repository at this point in the history

  14. Tinkering with helper function

    @tannerdolby
    tannerdolby committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    ddb074b View commit details
    Browse the repository at this point in the history

  15. Debugging

    @tannerdolby
    tannerdolby committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    0d41c0d View commit details
    Browse the repository at this point in the history

  16. Fallback to original extraction logic

    @tannerdolby
    tannerdolby committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    1107894 View commit details
    Browse the repository at this point in the history

  17. Revert to original to debug

    @tannerdolby
    tannerdolby committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    9fece47 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2022

  1. Replicate existing extraction logic for h4s

    @tannerdolby
    tannerdolby committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    7a839c0 View commit details
    Browse the repository at this point in the history

  2. Debugging

    @tannerdolby
    tannerdolby committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    f89d8b1 View commit details
    Browse the repository at this point in the history

  3. Testing

    @tannerdolby
    tannerdolby committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    86c61b7 View commit details
    Browse the repository at this point in the history

  4. Testing extraction behavior

    @tannerdolby
    tannerdolby committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    94f6e6e View commit details
    Browse the repository at this point in the history

  5. elements are getting removed, trying understand the flow better

    @tannerdolby
    tannerdolby committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    4e50ec9 View commit details
    Browse the repository at this point in the history

  6. Comment out the h4 extraction for now

    @tannerdolby
    tannerdolby committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    1a11752 View commit details
    Browse the repository at this point in the history