refactor(testing/tests): convert to typescript #6487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caugner
force-pushed
the
typescript-tests
branch
2 times, most recently
from
b619a0c
to
4fd6e42
Compare
github-actions
bot
added
dependencies
|
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
bot
removed
the
merge conflicts 🚧
caugner
force-pushed
the
typescript-tests
branch
3 times, most recently
from
78d53b6
to
e1201f3
Compare
github-actions
bot
removed
the
dependencies
LeoMcA
approved these changes
Jun 10, 2022
testing/tests/index.test.ts
Outdated
Comment on lines
1526
to
1527
| // @ts-ignore | ||
| const { hyData: { recentContributions } = {} } = JSON.parse( |
There was a problem hiding this comment.
Don't think this ts-ignore is necessary if you do:
const { hyData: { recentContributions = {} } = {} } = JSON.parse(
Otherwise it returns a Buffer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Converts
/testing/teststo TypeScript.How did you test this change?
scripts/testing.shandscripts/developing.shlocally.