-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to write solution files after every major iteration #187
Conversation
Codecov Report
@@ Coverage Diff @@
## master #187 +/- ##
==========================================
+ Coverage 43.10% 43.14% +0.03%
==========================================
Files 15 15
Lines 3519 3521 +2
==========================================
+ Hits 1517 1519 +2
Misses 2002 2002
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just added a couple of general comments, the PR looks good but others should review this
This is somehow broken at the moment. |
This is ready for review again |
Hey, sorry I did not saw this last commit and also slightly modified the docs myself. I agree with @marcomangano that calling it a Major iteration in any way is confusing. Great functionality, plus its useful for making convergence movies too! |
Purpose
This is another solver dev/debugging tool.
It makes it easy to print the solution after every major iterations to identify patterns in the converged states and residuals.
Type of change
Testing
add the option
writeSolutionEachIter
to a runscript.Checklist
flake8
andblack
to make sure the code adheres to PEP-8 and is consistently formatted