Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to write solution files after every major iteration #187

Merged
merged 7 commits into from
Feb 11, 2022

Conversation

joanibal
Copy link
Collaborator

@joanibal joanibal commented Feb 9, 2022

Purpose

This is another solver dev/debugging tool.
It makes it easy to print the solution after every major iterations to identify patterns in the converged states and residuals.

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

add the option writeSolutionEachIter to a runscript.

Checklist

  • I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@joanibal joanibal requested a review from a team as a code owner February 9, 2022 21:04
@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #187 (64be139) into master (9bfbeb2) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 64be139 differs from pull request most recent head bbdf017. Consider uploading reports for the commit bbdf017 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #187      +/-   ##
==========================================
+ Coverage   43.10%   43.14%   +0.03%     
==========================================
  Files          15       15              
  Lines        3519     3521       +2     
==========================================
+ Hits         1517     1519       +2     
  Misses       2002     2002              
Impacted Files Coverage Δ
adflow/pyADflow.py 67.48% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bfbeb2...bbdf017. Read the comment docs.

@joanibal joanibal requested a review from anilyil February 9, 2022 21:35
@joanibal joanibal changed the title Optional write solution files after every major iteration Optionally write solution files after every major iteration Feb 9, 2022
@joanibal joanibal changed the title Optionally write solution files after every major iteration Option to write solution files after every major iteration Feb 9, 2022
Copy link
Contributor

@marcomangano marcomangano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added a couple of general comments, the PR looks good but others should review this

adflow/pyADflow.py Show resolved Hide resolved
doc/options.yaml Outdated Show resolved Hide resolved
@joanibal
Copy link
Collaborator Author

This is somehow broken at the moment.
Hold off on reviewing.

@joanibal
Copy link
Collaborator Author

This is ready for review again

@anilyil
Copy link
Contributor

anilyil commented Feb 11, 2022

Hey, sorry I did not saw this last commit and also slightly modified the docs myself. I agree with @marcomangano that calling it a Major iteration in any way is confusing. Great functionality, plus its useful for making convergence movies too!

@sseraj sseraj merged commit 1550a32 into mdolab:master Feb 11, 2022
@joanibal joanibal deleted the conv_pics branch March 28, 2022 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants