Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated pyHyp options #23

Merged
merged 1 commit into from
Jan 4, 2021
Merged

Conversation

sseraj
Copy link
Collaborator

@sseraj sseraj commented Jan 4, 2021

Purpose

Changes to the pyHyp options handling here will break the script in simpleOCart. I updated the options so that it will work with the new pyHyp update. These options will also work with older versions of pyHyp, and the mesh generation functionality is unchanged.

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

I ran the mesh generation script in the overset tutorial to check that this works.

Checklist

Put an x in the boxes that apply.

  • I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@sseraj sseraj requested a review from a team as a code owner January 4, 2021 17:36
Copy link
Contributor

@marcomangano marcomangano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very easy review :) We don't even need to wait for the main pyHyp PR to merge this, right?

@sseraj
Copy link
Collaborator Author

sseraj commented Jan 4, 2021

That's right. This will work with the current version of pyHyp as well.

@marcomangano marcomangano merged commit 7ab8bee into mdolab:master Jan 4, 2021
@sseraj sseraj deleted the pyhyp-options branch January 4, 2021 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants