-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize code to F2008 #42
Conversation
@@ -2622,7 +2622,7 @@ subroutine convertPlot3d(pFile, cFile) | |||
zoneLoop: do iZone=1, nZones | |||
|
|||
! Write the zone itself. | |||
write(zoneName, "((a) (I5))") 'Domain.', izone | |||
write(zoneName, "((a), (I5))") 'Domain.', izone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comma makes sense to me, but are the parentheses required? I am not sure what they are doing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not familiar with file IO specifications, not really sure :/ maybe @anily knows?
If we are planning on eventually updating to 2008 on all our codes, then would it makes sense to just knock that out here? I suspect it may already be 2008 compliant, or at least very close. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the tests are working and the update is complete, I am fine with merging this. I am just changing the PR title to avoid confusion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is all fine, looks the same as what I had for my corrections to pyHyp. As for the parentheses question I think they just signify groupings, which in this case doesn't matter so it should be fine with or without them.
Purpose
I had to use F2003 because certain features were relying on it. Code can also be compiled on GCC 10 now.
Type of change
What types of change is it?
Select the appropriate type(s) that describe this PR
Testing
Tests pass with the new
-std
flag.Checklist
Put an
x
in the boxes that apply.flake8
andblack
to make sure the code adheres to PEP-8 and is consistently formatted