Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize code to F2008 #42

Merged
merged 5 commits into from
Jul 13, 2021
Merged

Standardize code to F2008 #42

merged 5 commits into from
Jul 13, 2021

Conversation

ewu63
Copy link
Collaborator

@ewu63 ewu63 commented Jul 5, 2021

Purpose

I had to use F2003 because certain features were relying on it. Code can also be compiled on GCC 10 now.

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Tests pass with the new -std flag.

Checklist

Put an x in the boxes that apply.

  • I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@ewu63 ewu63 requested a review from a team as a code owner July 5, 2021 15:34
@ewu63 ewu63 requested review from eirikurj and akleb July 5, 2021 15:34
src/cgns_utilities.F90 Show resolved Hide resolved
@@ -2622,7 +2622,7 @@ subroutine convertPlot3d(pFile, cFile)
zoneLoop: do iZone=1, nZones

! Write the zone itself.
write(zoneName, "((a) (I5))") 'Domain.', izone
write(zoneName, "((a), (I5))") 'Domain.', izone
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comma makes sense to me, but are the parentheses required? I am not sure what they are doing.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not familiar with file IO specifications, not really sure :/ maybe @anily knows?

@akleb
Copy link
Contributor

akleb commented Jul 8, 2021

If we are planning on eventually updating to 2008 on all our codes, then would it makes sense to just knock that out here? I suspect it may already be 2008 compliant, or at least very close.

Copy link
Contributor

@marcomangano marcomangano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the tests are working and the update is complete, I am fine with merging this. I am just changing the PR title to avoid confusion

@marcomangano marcomangano changed the title Standardize code to F2003 Standardize code to F2008 Jul 8, 2021
Copy link
Contributor

@akleb akleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is all fine, looks the same as what I had for my corrections to pyHyp. As for the parentheses question I think they just signify groupings, which in this case doesn't matter so it should be fine with or without them.

@ewu63 ewu63 merged commit cc29c74 into master Jul 13, 2021
@ewu63 ewu63 deleted the fix-f2003 branch July 13, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants