Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bounding box function and mirrorGrid changes #59

Merged
merged 5 commits into from
Sep 28, 2022
Merged

Conversation

anilyil
Copy link
Contributor

@anilyil anilyil commented Sep 23, 2022

This PR replicates the changes in #58. The old PR was closed w/o merging because of conflicts I did not want to deal with.

Here, I added the method to get the bounding boxes from grids, which can be then used to fine tune the cartesian grid coordinates in: mdolab/pyhyp#65 I also made slight modifications to the mirror grid call because it was not working for what I needed to do. Finally, a new function to mirror surface grids (the default mirror only works on volume)

Purpose

Expected time until merged

few days

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@anilyil anilyil requested a review from a team as a code owner September 23, 2022 19:40
@anilyil anilyil requested review from ArshSaja and removed request for joanibal September 23, 2022 19:47
@anilyil
Copy link
Contributor Author

anilyil commented Sep 23, 2022

I changed the mirror behavior so that the _mirror grids have the same trailing index as the original grid. I find this more useful when I am trying to map which block mirrors to which in tecplot etc

@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Merging #59 (7868db1) into main (1040111) will increase coverage by 0.09%.
The diff coverage is 84.00%.

@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
+ Coverage   21.79%   21.89%   +0.09%     
==========================================
  Files           3        3              
  Lines        2271     2279       +8     
==========================================
+ Hits          495      499       +4     
- Misses       1776     1780       +4     
Impacted Files Coverage Δ
cgnsutilities/cgns_utils.py 0.00% <0.00%> (ø)
cgnsutilities/cgnsutilities.py 27.79% <91.30%> (+0.11%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

ArshSaja
ArshSaja previously approved these changes Sep 26, 2022
Copy link
Collaborator

@sseraj sseraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. One comment though:

@sseraj sseraj changed the title Several additions to grid methods Bounding box function and mirrorGrid changes Sep 28, 2022
@sseraj sseraj merged commit aaa5b66 into mdolab:main Sep 28, 2022
@anilyil anilyil deleted the mods branch May 31, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants