Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fprettify #72

Merged
merged 2 commits into from
Aug 18, 2022
Merged

fprettify #72

merged 2 commits into from
Aug 18, 2022

Conversation

sseraj
Copy link
Collaborator

@sseraj sseraj commented Aug 10, 2022

Purpose

Formatting the Fortran code with fprettify

Expected time until merged

1 week

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Current tests pass

Checklist

  • I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@sseraj sseraj requested a review from a team as a code owner August 10, 2022 17:37
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #72 (e2fdd60) into main (e90267a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #72   +/-   ##
=======================================
  Coverage   73.43%   73.43%           
=======================================
  Files           6        6           
  Lines         753      753           
=======================================
  Hits          553      553           
  Misses        200      200           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link

@lamkina lamkina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This made my OCD happy.

Copy link
Collaborator

@ewu63 ewu63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ewu63 ewu63 merged commit 30494f5 into main Aug 18, 2022
@ewu63 ewu63 deleted the fprettify branch August 18, 2022 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants