Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added simple rtotp binary #35

Merged
merged 6 commits into from
Jan 15, 2015
Merged

Added simple rtotp binary #35

merged 6 commits into from
Jan 15, 2015

Conversation

halo
Copy link
Contributor

@halo halo commented Dec 15, 2014

While I understand that this is a pure library, I find myself often just wanting to generate a token from a salt without too much work. Much like HTTParty I though a small binary to accomplish this might not hurt.

Do you think an executable like this would be useful? I doubt that the name of the executalbe is very useful, but it is almost guaranteed to not cause a conflict :)

Thank you for your feedback.

@halo halo closed this Jan 12, 2015
@mdp
Copy link
Owner

mdp commented Jan 13, 2015

Hey, sorry for not getting back to you on this. I actually think this would be a useful addition as well.

You pull request looks like a great start, but ideally it would allow for both HOTP and TOTP tokens as well as using the Ruby OptionParser for argument parsing and maybe a small but simple test.

Anyways, I'm a bit swamped at the moment, but I'll try and add this in the near future.

Thanks,
Mark

@halo
Copy link
Contributor Author

halo commented Jan 13, 2015

Thank you for your feedback. I will gladly implement those things. Hang on for an update.

@halo
Copy link
Contributor Author

halo commented Jan 14, 2015

Would you mind giving me feedback on the look and feel of the output of the executable? Is it intuitive for you so far? Should it also be able to generate URI's? There are still some holes in the spec coverage but you can at least try it out now.

PS: Funny enough, there appears to be more code for the CLI now than for the core functionality ;)

mdp added a commit that referenced this pull request Jan 15, 2015
Added simple rtotp binary
@mdp mdp merged commit 2aa3709 into mdp:master Jan 15, 2015
@mdp
Copy link
Owner

mdp commented Jan 15, 2015

Looks really good, I think the coverage is fine for this, as it's not critical to the core product, it's more of a helpful addition for debugging.

I'll do a quick pass tonight and add it to the README and bump the version.

Thanks again

@halo
Copy link
Contributor Author

halo commented Jan 16, 2015

Awesome! Thank you. I thought I'd get you kickstarted with the README: #37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants