Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add methods to manipulate Summary Word Count #16

Merged
merged 2 commits into from
May 27, 2023

Conversation

aerkiaga
Copy link
Contributor

This adds methods word_count, set_word_count and clear_word_count to SummaryInfo, which can be used to set the Word Count field within the Summary. This is necessary for many use cases, since the default value is 0, while a typical installer containing compressed files should set it to 2.

@mdsteele
Copy link
Owner

Looks good, thanks! Could you please exercise these new methods in the set_properties() test at the bottom of the file? Also I think you'll need to run cargo fmt to make the linter happy.

@mdsteele
Copy link
Owner

Thanks!

@aerkiaga aerkiaga deleted the word_count branch May 27, 2023 12:05
@mdsteele
Copy link
Owner

I've just published msi v0.6.0 with this new feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants