Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Volar 2.4 #460

Merged
merged 6 commits into from
Aug 19, 2024
Merged

Conversation

johnsoncodehk
Copy link
Contributor

@johnsoncodehk johnsoncodehk commented Jul 21, 2024

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Update to Volar 2.4 alpha, this is mainly to get a few fixes for Ts plugin.

Fixes #451
Fixes #457

Copy link

changeset-bot bot commented Jul 21, 2024

🦋 Changeset detected

Latest commit: 71ca336

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@mdx-js/typescript-plugin Patch
@mdx-js/language-service Patch
@mdx-js/language-server Patch
vscode-mdx Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Jul 21, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@f77645b). Learn more about missing BASE report.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #460   +/-   ##
=======================================
  Coverage        ?   91.45%           
=======================================
  Files           ?       10           
  Lines           ?     1604           
  Branches        ?        0           
=======================================
  Hits            ?     1467           
  Misses          ?      137           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnsoncodehk johnsoncodehk marked this pull request as draft July 22, 2024 03:24
@johnsoncodehk johnsoncodehk marked this pull request as ready for review July 22, 2024 04:00
Copy link
Member

@remcohaszing remcohaszing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! I’m going to wait for 2.4, but it looks great so far. I verified that @styled/typescript-styled-plugin now works as expected.

packages/language-server/index.js Outdated Show resolved Hide resolved
@remcohaszing remcohaszing added 🦋 type/enhancement This is great to have 📦 area/deps This affects dependencies 👶 semver/patch This is a backwards-compatible fix 👍 phase/yes Post is accepted and can be worked on labels Jul 23, 2024
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Jul 23, 2024
Copy link
Contributor

Hi! This is accepted and can go somewhere!

Team: please review this PR and use the area/* (to describe the scope of the change), platform/* (if this is related to a specific one), and semver/* and type/* labels to annotate this.

@johnsoncodehk
Copy link
Contributor Author

Neat! I’m going to wait for 2.4, but it looks great so far. I verified that @styled/typescript-styled-plugin now works as expected.

What about releasing the VSCode extension first? 2.4 may not be released quickly.

@johnsoncodehk johnsoncodehk changed the title Update to Volar 2.4 alpha Update to Volar 2.4 Aug 18, 2024
@remcohaszing remcohaszing merged commit 163f4bc into mdx-js:main Aug 19, 2024
4 checks passed
Copy link
Contributor

Hi! This was closed. Team: If this was merged, please describe when this is likely to be released. Otherwise, please add one of the no/* labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 area/deps This affects dependencies 👍 phase/yes Post is accepted and can be worked on 👶 semver/patch This is a backwards-compatible fix 🦋 type/enhancement This is great to have
3 participants