Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template strings inside code blocks are broken after 0.19 #430

Closed
johno opened this issue Mar 2, 2019 · 0 comments
Closed

Template strings inside code blocks are broken after 0.19 #430

johno opened this issue Mar 2, 2019 · 0 comments
Labels
🐛 type/bug This is a problem

Comments

@johno
Copy link
Member

johno commented Mar 2, 2019 •
edited
Loading

The additional escaping that was added unescapes template literal escaping.

MDX that causes an issue: https://raw.githubusercontent.com/gatsbyjs/gatsby/master/packages/gatsby-source-filesystem/README.md
@johno johno added the 🐛 type/bug This is a problem label Mar 2, 2019
@ChristopherBiscardi ChristopherBiscardi mentioned this issue Mar 2, 2019
Closed
johno added a commit that referenced this issue Mar 2, 2019
@johno
Fix template string escaping
010321c 
We need to escape template strings after back slash
escaping so that unescaping template strings doesn't
happen by accident.

---

Fixes #430
@johno johno mentioned this issue Mar 2, 2019
Merged
@johno johno closed this as completed in #431 Mar 2, 2019
johno added a commit that referenced this issue Mar 2, 2019
@johno
Fix template string escaping (#431)
c0f2a21 
We need to escape template strings after back slash
escaping so that unescaping template strings doesn't
happen by accident.

---

Fixes #430
@ahmedelgabri ahmedelgabri mentioned this issue Mar 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 type/bug This is a problem
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johno