Add better errors when referencing missing components #1811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, React or other JSX runtimes threw rather hard to read errors when a component was undefined (because it wasn’t imported, passed, or provided), essentially only pointing to *something* missing. Now we throw proper errors when a component is missing at runtime, including what exact component (or object) is undefined. In addition, this adds a `development` option, which defaults to `false` but can be configured explicitly or turned on with `NODE_ENV=development`. When it’s `true`, the exact place that references the missing component or object, and which file did that, is included in the error message. Related-to: #1775. Backports: wooorm/xdm@62e6f30.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, React or other JSX runtimes threw rather hard to read errors
when a component was undefined (because it wasn’t imported, passed, or
provided), essentially only pointing to something missing.
Now we throw proper errors when a component is missing at runtime,
including what exact component (or object) is undefined.
In addition, this adds a
developmentoption, which defaults tofalsebut can be configured explicitly or turned on withNODE_ENV=development.When it’s
true, the exact place that references the missing componentor object, and which file did that, is included in the error message.
Related-to: #1775.
Backports: wooorm/xdm@62e6f30.