Fix newline issue in paragraphs #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johno
force-pushed
the
newline-to-space
branch
from
1875ded
to
aaf0e1a
Compare
johno
changed the title
wooorm
reviewed
Feb 26, 2019
In paragraph nodes newlines were being removed which causes issues when there are two subsequent nodes like links, spans, emphasis, bold, etc. Now, if the parent node is a paragraph tag, we preserve the newline since it's significant and results in a space that separates two inline nodes on render. --- Closes #412
johno
force-pushed
the
newline-to-space
branch
from
aaf0e1a
to
c075aef
Compare
|
Thank you so much! |
This was referenced Nov 13, 2019
This was referenced Jan 7, 2020
This was referenced Mar 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In paragraph nodes newlines were being removed which causes
issues when there are two subsequent nodes like links, spans,
emphasis, bold, etc.
Now, if the parent node is a paragraph tag, we preserve the
newline since it's significant and results in a space that
separates two inline nodes on render.
Closes #412