feat: Cross-Household Recipes #4089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hay-kot
previously approved these changes
Aug 31, 2024
frontend/components/Domain/Recipe/RecipePage/RecipePageParts/RecipePageHeader.vue
Outdated
Show resolved
Hide resolved
| @@ -46,6 +47,9 @@ def __init__(self, repos: AllRepositories, user: PrivateUser, household: Househo | |||
| if repos.household_id != user.household_id != household.id: | |||
| raise Exception("household ids do not match") | |||
|
|
|||
| self.group_recipes = get_repositories(repos.session, group_id=repos.group_id, household_id=None).recipes | |||
| """Recipes repo without a Household filter""" | |||
hay-kot
approved these changes
Sep 1, 2024
boc-the-git
pushed a commit
to boc-the-git/mealie
that referenced
this pull request
Sep 28, 2024
boc-the-git
pushed a commit
to boc-the-git/mealie
that referenced
this pull request
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
Partial implementation of #4081. This PR allows users to see recipes from other households. More specifically:
There are a few restrictions:
Which issue(s) this PR fixes:
(REQUIRED)
Partial implementation of #4081
Special notes for your reviewer:
(fill-in or delete this section)
This implementation assumes we're never going to allow users to hide recipes from other household members. Users can hide the entire household from public users. Supporting hiding from other household users would add an immense amount of complexity (e.g. what happens if a recipe on my shopping list suddenly becomes hidden?), so personally I never see that being an option.
Testing
(fill-in or delete this section)
Pytest for backend. Checked around the frontend a bunch and everything works as expected.