Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Shopping list UI overhaul - label sorted by default #4238

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

Wetzel402
Copy link
Contributor

What type of PR is this?

  • feature

What this PR does / why we need it:

  • Default to the label sorted view rather than the unsorted view

Which issue(s) this PR fixes:

#4077

Testing

Tested in dev container

Copy link
Collaborator

@Kuchenpirat Kuchenpirat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are ignoring the case that many people don't label their foods, so for them everything will always be grouped under "No Label"
But since preferences are persistent it should be fine.
If not it is super easily reversible

@Kuchenpirat Kuchenpirat merged commit e971efd into mealie-recipes:mealie-next Sep 19, 2024
13 checks passed
@Wetzel402 Wetzel402 deleted the label_sorted branch September 26, 2024 21:02
boc-the-git pushed a commit to boc-the-git/mealie that referenced this pull request Sep 28, 2024
boc-the-git pushed a commit to boc-the-git/mealie that referenced this pull request Sep 28, 2024
Choromanski pushed a commit to Choromanski/mealie that referenced this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants