Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPC isn’t detected #323

Closed
Tracked by #605
Leonick opened this issue Oct 16, 2021 · 11 comments
Closed
Tracked by #605

UPC isn’t detected #323

Leonick opened this issue Oct 16, 2021 · 11 comments
Assignees

Comments

@Leonick
Copy link

Leonick commented Oct 16, 2021

Describe the bug
UPC-A and UPC-E codes doesn't seem to be detected even when configured to

I've tried both my own implementation of Html5Qrcode and with you example page. Tried your example UPC pictures, several codes on actual product boxes, and picture from Google search. None are detected.

Other barcodes such as EAN work.

Screenshots
If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information):

  • Device: iPhone Mini 12 and iPhone 7
  • OS: iOS 15 and iOS 14
  • Browser: Safari

Additional context
image
image
image

@mebjas
Copy link
Owner

mebjas commented Oct 26, 2021

Can you try with following config

var config = { 
    fps: 10,
    qrbox: {width: 250, height: 250},
    // Important notice: this is experimental feature, use it at your
    // own risk. See documentation in
    // mebjas@/html5-qrcode/src/experimental-features.ts
    experimentalFeatures: {
        useBarCodeDetectorIfSupported: true
    },
};

@Leonick
Copy link
Author

Leonick commented Oct 26, 2021

Unfortunately not, as the BarcodeDetector API isn't supported by Safari on iOS.

@vishakha-simply
Copy link

@Leonick hey did you find any solution to this ?
I'm struggling with the same

@Leonick
Copy link
Author

Leonick commented Nov 6, 2021

@vishakha-simply
I did not. Had to use a different solution. github.com/ericblade/quagga2
Examples are out of date and documentation not as good so bit trickier to set up, but it works.

@ROBERT-MCDOWELL
Copy link

why not to grab the quagga2 code that works with UPC code an integrte it in html5-qrcode?

@mebjas mebjas self-assigned this Dec 20, 2021
@marcinheniborg
Copy link

Hey @mebjas,
awesome job with this repo. Thanks! I'm really excited to use it with the inventory app that I'm developing based on the Google App Script. However I'm experiencing the same issues as other commenters. The app is not scanning codes from the popular items which are with UPC codes. Do you foresee looking into this anytime soon?
Thank you!

@erikmillergalow
Copy link

@mebjas Do you have a sense of whether or not a fix for iOS barcode scanning will make it into any releases in the near future? I'm evaluating this package to replace quagga, the speed and accuracy is great but I need to support both Android and iOS.

@gbsystems
Copy link

2.2.1 Not scanning for me in FF+Chrome on Android
+1 for rectification of this bug, spoiling an otherwise excellent piece of software

@mebjas
Copy link
Owner

mebjas commented Oct 30, 2022

Will look into this based on @Breno1288 's PR.

To be tracked for v2.2.7

@mebjas
Copy link
Owner

mebjas commented Nov 16, 2022

Fixed in zxing-js. Will be published in version 2.3.1. Now UPC-A and UPC-E will get scanned without useBarCodeDetectorIfSupported support - thus across platform.

Track progress on this version at: #605

@mebjas
Copy link
Owner

mebjas commented Nov 16, 2022

Issue fixed with version 2.3.1 -- please help with verification (please comment in issue #605 if the issue is still reproduced in certain platform).

Github release: https://github.com/mebjas/html5-qrcode/releases/tag/v2.3.1
NPM: https://www.npmjs.com/package/html5-qrcode/v/2.3.1

Closing this issue for now.

@mebjas mebjas closed this as completed Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants