Update zxing-js library so UPC-A barcodes scan as expected #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 to merge this |
|
Thanks for the PR, I'll send a cleaned up version of this and submit it after testing / eval (will CC you). |
Merged
|
@Breno1288 appreciate the changes. I have made another pull request with your changes (+ some formatting). Committed on your behalf. Plan to submit this and release as part of v2.3.1 after testing and verification. Closing this PR, please feel free to reply on the other PR directly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the simple getting started example independently, or using the scanapp.org live example, UPC-A barcodes don't scan or register unless you are on a supported version of Chome on Android with the experimentalFeatures useBarCodeDetectorIfSupported set to true.
When using an iPhone and relying on the Zxing implementation, the barcodes do not scan.
Seen reported in other issues like #323 or #487
I have grabbed the latest copy of the Zxing-js library from it's repository and rebuilt the umd dependencies that this library is relying on.
Now testing it locally on an iPhone I have been able to successfully scan all the UPC-A barcodes I have, as well as the sample images provided in the above mentioned GitHub Issues.