Bugfix frozen screen on Chrome (Android) #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the videoTrack without removing it from the stream first.
|
Thanks for the posting the issue and the fix for this. Would it be possible to pull the latest changes from master and rebuild the transpiled version and minified js. Alternatively (& preferred way now) would be to just push the main js change, I'll merge and transpile and publish latest version to Github / nmp. |
# Conflicts: # minified/html5-qrcode.min.js
|
@mebjas: I have merged the changes from master into my branch and retranspiled the minified files. As mentioned in the issue #159 by @jdtimmerman, one test is still failing. |
This was referenced Apr 19, 2021
|
Thanks for this, merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue where Chrome on Android would freeze when trying to stop the videoTrack without removing it from the stream first.
This bug was already mentioned in issue #159.
After Googling, it seemed that there was a known issue with this in Chrome, where another GitHub user found a solution to it here.
I also committed the updated Babel compilation files: if this is not supposed to be done upon a merge request, please let me know, then I will undo these changes.