Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we call the
start
function of theHtml5QrCode
object, the promise was resolved before the video from the camera is ready/rendered, thus making it currently not possible to chain the promise of thestart
function with other operations likestop
,pause
, etc.Also, the exceptions thrown inside .play() promise were not being handled
Before (Chaining with pause)
After (Chaining with pause)
Before (Chaining with stop)
After (Chaining with stop)