Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add a comment for trusted_block_* fields in proto #562

Merged
merged 2 commits into from
Dec 21, 2022
Merged

chore: add a comment for trusted_block_* fields in proto #562

merged 2 commits into from
Dec 21, 2022

Conversation

youngjoon-lee
Copy link
Contributor

@youngjoon-lee youngjoon-lee commented Dec 21, 2022 •
edited
Loading

@youngjoon-lee youngjoon-lee added this to the v2.1.0-beta milestone Dec 21, 2022
@youngjoon-lee youngjoon-lee changed the title chore: add a comment for trusted_block_* fields in proto chore: add a comment for trusted_block_* fields in proto Dec 21, 2022
audtlr24
audtlr24 approved these changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@audtlr24 audtlr24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

0xHansLee
0xHansLee approved these changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@0xHansLee 0xHansLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gyuguen
gyuguen approved these changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@gyuguen gyuguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youngjoon-lee youngjoon-lee merged commit e7f012a into main Dec 21, 2022
@youngjoon-lee youngjoon-lee deleted the chore/44 branch December 21, 2022 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xHansLee 0xHansLee 0xHansLee approved these changes

@audtlr24 audtlr24 audtlr24 approved these changes

@gyuguen gyuguen gyuguen approved these changes

@cl9200 cl9200 Awaiting requested review from cl9200 cl9200 is a code owner

@inchori inchori Awaiting requested review from inchori

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.1.0-alpha.3
Development

Successfully merging this pull request may close these issues.
4 participants
@youngjoon-lee @gyuguen @audtlr24 @0xHansLee