feat: proto for oracle upgrade and its skeleton #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Youngjoon Lee <[email protected]>
…nto ft/569/oracle-upgrade-handler # Conflicts: # cmd/panacead/cmd/genoracle.go # proto/panacea/oracle/v2/oracle.proto
0xHansLee
requested review from
cl9200,
youngjoon-lee,
gyuguen,
inchori and
audtlr24
as code owners
added 2 commits
December 26, 2022 17:31
0xHansLee
commented
Dec 26, 2022
Comment on lines
+6
to
+7
| EventTypeUpgrade = "oracle_upgrade" | ||
| EventTypeApproveOracleUpgrade = "approve_oracle_upgrade" |
There was a problem hiding this comment.
Also, add separate event for oracle upgrade. This event type will be used in oracle side.
…nto ft/570/upgrade-endblocker
…ft/575/upgrade-proto # Conflicts: # proto/panacea/oracle/v2/oracle.proto # proto/panacea/oracle/v2/proposal.proto # proto/panacea/oracle/v2/query.proto # x/oracle/types/keys.go # x/oracle/types/oracle.pb.go # x/oracle/types/query.pb.go # x/oracle/types/query.pb.gw.go
|
I merged #578 into this branch and changed base branch to |
added 4 commits
December 28, 2022 09:56
|
I think seperating OracleRegistration and OracleUpgrade is a good choice. |
|
I too think the Let's think about this. |
# Conflicts: # proto/panacea/oracle/v2/oracle.proto # proto/panacea/oracle/v2/query.proto # x/oracle/keeper/upgrade.go # x/oracle/keeper/upgrade_test.go # x/oracle/types/keys.go # x/oracle/types/oracle.pb.go # x/oracle/types/query.pb.go # x/oracle/types/query.pb.gw.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #575
proto messages and skeleton code for the txs and queries.
Apart from
OracleRegistration, I definedOracleUpgradewhich is a set forMsgUpgradeOraclefor now. When developing functions, if it seems that it is better to combine them, then let's merge them.BTW, the name of
OracleUpgradeis little bit confusing, so if you have any good idea for this, please feel free to leave your thoughts.