Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Cosmos SDK to v0.37.15 #58

Merged
merged 4 commits into from
Oct 15, 2020
Merged

Upgrade Cosmos SDK to v0.37.15 #58

merged 4 commits into from
Oct 15, 2020

Conversation

youngjoon-lee
Copy link
Contributor

@youngjoon-lee youngjoon-lee commented Sep 25, 2020

Closes #53

Changes

There are so many breaking changes when upgrading medibloc/cosmos-sdk from v0.34.7 to v0.37.15.

  1. Most of boilerplate codes were moved into the cosmos-sdk. So, many Go packages were removed from the panacea-core.

    app/genesis.go
    app/invariants.go
    init/{collect.go, genesis_accts.go, gentx.go, ...}
    server/
    types/assets/
    version/
    
    • It also caused many changes in the app/app.go and cmd/**/main.go, but most of them are straight-forward fortunately.
    • Especially, the custom parameter definitions in the app/genesis.go were moved to the medibloc/cosmos-sdk repo. Please see Modify default genesis params for Panacea cosmos-sdk#3.
  2. The x/**/module.go was added.

    • For the latest cosmos-sdk, each module (x/) must implement AppModuleBasic and AppModule, so that they can be managed by ModuleManager. (link)
  3. The x/**/keeper.go and some keeper-related codes were moved into the x/**/keeper/, according to the new recommended directory structure.

  4. The genesis-related types were moved into the x/**/types/, according to the new recommended directory structure.

Tests

  • Unit tests
  • Running panacead from scratch
  • AOL/DID operations

@youngjoon-lee youngjoon-lee force-pushed the ft/na/fresh branch 3 times, most recently from 1245960 to 79825ff Compare October 13, 2020 09:15
@youngjoon-lee youngjoon-lee changed the title Bump Cosmos SDK version to v0.37.14-internal + related changes Upgrade Cosmos SDK to v0.37.14-internal + related changes Oct 14, 2020
Copy link
Contributor

@cl9200 cl9200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@youngjoon-lee youngjoon-lee changed the title Upgrade Cosmos SDK to v0.37.14-internal + related changes Upgrade Cosmos SDK to v0.37.15 Oct 15, 2020
@youngjoon-lee
Copy link
Contributor Author

I also tested all commands in our manual. All works well. I'd say this PR is safe to be merged.

@youngjoon-lee youngjoon-lee merged commit dfbaa62 into master Oct 15, 2020
@youngjoon-lee youngjoon-lee deleted the ft/na/fresh branch October 15, 2020 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Cosmos SDK
2 participants