chore: rename ApproveOracleRegistration to reuse #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Youngjoon Lee <[email protected]>
…nto ft/569/oracle-upgrade-handler # Conflicts: # cmd/panacead/cmd/genoracle.go # proto/panacea/oracle/v2/oracle.proto
…nto ft/570/upgrade-endblocker
…ft/571/upgrade-oracle-tx # Conflicts: # proto/panacea/oracle/v2/oracle.proto # proto/panacea/oracle/v2/proposal.proto # proto/panacea/oracle/v2/query.proto # x/oracle/types/errors.go # x/oracle/types/keys.go # x/oracle/types/oracle.go # x/oracle/types/oracle.pb.go # x/oracle/types/query.pb.go # x/oracle/types/query.pb.gw.go
…ft/575/upgrade-proto # Conflicts: # proto/panacea/oracle/v2/oracle.proto # proto/panacea/oracle/v2/proposal.proto # proto/panacea/oracle/v2/query.proto # x/oracle/types/keys.go # x/oracle/types/oracle.pb.go # x/oracle/types/query.pb.go # x/oracle/types/query.pb.gw.go
This reverts commit 44a3f47.
…upgrade" This reverts commit f73a2ca.
…1/upgrade-oracle-tx # Conflicts: # proto/panacea/oracle/v2/oracle.proto # proto/panacea/oracle/v2/proposal.proto # x/oracle/keeper/grpc_query_oracle.go # x/oracle/types/keys.go # x/oracle/types/oracle.pb.go
0xHansLee
requested review from
cl9200,
youngjoon-lee,
gyuguen,
inchori and
audtlr24
as code owners
inchori
approved these changes
Jan 3, 2023
| @@ -48,12 +48,12 @@ message MsgRegisterOracleResponse { | |||
|
|
|||
| // MsgApproveOracleRegistration defines the Msg/ApproveOracleRegistration | |||
| message MsgApproveOracleRegistration { | |||
| ApproveOracleRegistration approve_oracle_registration = 1; | |||
| ApprovalSharingOracleKey approval_sharing_oracle_key = 1; | |||
There was a problem hiding this comment.
How about renaming like SharingOracleKeyApproval?
There was a problem hiding this comment.
Or.. MsgEncryptedOraclePrivKey..?
There was a problem hiding this comment.
Hmm.... I think that the ApprovalSharingOracleKey is more better. 😂
Co-authored-by: Hansol Lee <[email protected]>
added 2 commits
January 4, 2023 11:28
…oracle-reg # Conflicts: # proto/panacea/oracle/v2/tx.proto # x/oracle/abci.go # x/oracle/abci_test.go # x/oracle/keeper/upgrade.go # x/oracle/types/message_oracle.go # x/oracle/types/oracle.go # x/oracle/types/tx.pb.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I renamed the
ApproveOracleRegistrationtoApprovalSharingOracleKeyto reuse inMsgApproveOracleUpgrade.