feat: implement approve oracle upgrade tx #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Youngjoon Lee <[email protected]>
…nto ft/569/oracle-upgrade-handler # Conflicts: # cmd/panacead/cmd/genoracle.go # proto/panacea/oracle/v2/oracle.proto
…nto ft/570/upgrade-endblocker
…ft/571/upgrade-oracle-tx # Conflicts: # proto/panacea/oracle/v2/oracle.proto # proto/panacea/oracle/v2/proposal.proto # proto/panacea/oracle/v2/query.proto # x/oracle/types/errors.go # x/oracle/types/keys.go # x/oracle/types/oracle.go # x/oracle/types/oracle.pb.go # x/oracle/types/query.pb.go # x/oracle/types/query.pb.gw.go
…ft/575/upgrade-proto # Conflicts: # proto/panacea/oracle/v2/oracle.proto # proto/panacea/oracle/v2/proposal.proto # proto/panacea/oracle/v2/query.proto # x/oracle/types/keys.go # x/oracle/types/oracle.pb.go # x/oracle/types/query.pb.go # x/oracle/types/query.pb.gw.go
This reverts commit 44a3f47.
…upgrade" This reverts commit f73a2ca.
…1/upgrade-oracle-tx # Conflicts: # proto/panacea/oracle/v2/oracle.proto # proto/panacea/oracle/v2/proposal.proto # x/oracle/keeper/grpc_query_oracle.go # x/oracle/types/keys.go # x/oracle/types/oracle.pb.go
0xHansLee
requested review from
youngjoon-lee,
gyuguen,
inchori and
audtlr24
as code owners
0xHansLee
commented
Dec 30, 2022
Comment on lines
-15
to
-18
| if err := oracleRegistration.ValidateBasic(); err != nil { | ||
| return err | ||
| } | ||
|
|
There was a problem hiding this comment.
As commented in the previous PR, I deleted this validation.
0xHansLee
commented
Dec 30, 2022
| @@ -133,10 +132,11 @@ func (suite *oracleTestSuite) TestRegisterOracleSuccess() { | |||
| suite.Require().Equal(suite.oracleCommissionMaxChangeRate, oracleFromKeeper.OracleCommissionMaxChangeRate) | |||
| } | |||
|
|
|||
| func (suite *oracleTestSuite) TestRegisterOracleFailedValidateToMsgOracleRegistration() { | |||
There was a problem hiding this comment.
Accordingly this, deleted validation test code.
audtlr24
approved these changes
Dec 30, 2022
x/oracle/keeper/oracle.go
Outdated
Comment on lines
105
to
106
| if err != nil || !existing { | ||
| return fmt.Errorf("failed to check if the approver oracle exists or not. address(%s)", approval.ApproverOracleAddress) |
There was a problem hiding this comment.
How about splitting the error? It seems that the address may not be valid and the oracle may not be in the store.
There was a problem hiding this comment.
Got it. 1c69a6d
As you can see the commit, I changed the HasOracle function.
Because we should check if the oracle exists and is active as well. Thank you for pointing out.
gyuguen
approved these changes
Jan 3, 2023
| ), | ||
| ) | ||
|
|
||
| // TODO: add to queue(?) for update unique ID |
There was a problem hiding this comment.
As discussed offline, it seems that you can check if the encryptedOraclePrivKey of OracleUpgrade is not nil without putting it in the queue.
There was a problem hiding this comment.
Okay, I understand. I will reflect it in PR #584.
Co-authored-by: Hansol Lee <[email protected]>
…oracle-reg # Conflicts: # proto/panacea/oracle/v2/tx.proto # x/oracle/abci.go # x/oracle/abci_test.go # x/oracle/keeper/upgrade.go # x/oracle/types/message_oracle.go # x/oracle/types/oracle.go # x/oracle/types/tx.pb.go
… into ft/574/approve-oracle-upgrade # Conflicts: # x/oracle/keeper/upgrade.go # x/oracle/types/errors.go
…-upgrade # Conflicts: # proto/panacea/oracle/v2/tx.proto # x/oracle/keeper/oracle.go # x/oracle/types/tx.pb.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #574
Implemented
MsgApproveOracleUpgradetransaction with some refactoring.