Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

112 handle cascade deletes #118

Merged
merged 6 commits into from
Jul 4, 2024
Merged

Conversation

njuguna-n
Copy link
Contributor

@njuguna-n njuguna-n commented Jul 1, 2024

Description

Add cascade deletes to models and use post hook to delete base models

medic/sync#112

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@njuguna-n njuguna-n requested a review from lorerod July 1, 2024 14:05
@njuguna-n njuguna-n marked this pull request as ready for review July 1, 2024 14:05
couch2pg/src/importer.js Outdated Show resolved Hide resolved
couch2pg/src/setup.js Outdated Show resolved Hide resolved
couch2pg/tests/unit/importer.spec.js Outdated Show resolved Hide resolved
couch2pg/tests/unit/importer.spec.js Outdated Show resolved Hide resolved
couch2pg/tests/unit/importer.spec.js Outdated Show resolved Hide resolved
tests/dbt/package/models/reports/reports.sql Outdated Show resolved Hide resolved
tests/e2e-test.spec.js Outdated Show resolved Hide resolved
tests/e2e-test.spec.js Outdated Show resolved Hide resolved
tests/e2e-test.spec.js Show resolved Hide resolved
tests/e2e-test.spec.js Show resolved Hide resolved
Copy link
Contributor

@lorerod lorerod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @njuguna-n deletes are working!
As you mentioned in comment I will keep working on reproducing the weird bug.

@njuguna-n njuguna-n merged commit 374132b into 112-dont-save-revs Jul 4, 2024
5 checks passed
@njuguna-n njuguna-n deleted the 112-handle-cascade-deletes branch July 4, 2024 17:22
njuguna-n added a commit that referenced this pull request Jul 5, 2024
* initial commit

* adds batch one unit tests

* adds more unit tests

* install on build

* remove logstash and small dbt image

* js e2e tests

* adds ignore scripts

* remove postgrest

* adds watcher tests

* rename test

* overwrite revs and introduce _deleted

* process edits and add basic models for e2e testing.

* 112 handle cascade deletes (#118)

* feat: rename @timestamp column

* feat: update models to match proposed base models and use cascade deletes

---------

Co-authored-by: Njuguna Ndung'u <[email protected]>
medic-ci pushed a commit that referenced this pull request Sep 10, 2024
# 1.0.0 (2024-09-10)

### Bug Fixes

* Change env variables according to cht pipeline updates ([#71](#71)) ([c89aadf](c89aadf))
* Fix numbering ([#50](#50)) ([5c93300](5c93300))

### Features

* **#107:** Adds multi-db watcher support ([#113](#113)) ([279d8f2](279d8f2)), closes [#107](#107) [#107](#107)
* **#112:** drop support for multiple copies of every document ([#115](#115)) ([b46f288](b46f288)), closes [#112](#112) [#118](#118)
* **#129:** add back automatic pipeline updates ([#130](#130)) ([fc73fd7](fc73fd7)), closes [#129](#129) [#129](#129) [#129](#129)
* **#1:** first release ([ff0fedd](ff0fedd)), closes [#1](#1)
* **#25:** custom databases ([#33](#33)) ([cd10db0](cd10db0)), closes [#25](#25)
* **#78:** full refresh on changed objects, only incremental runs continously ([0869ee9](0869ee9)), closes [#78](https://github.com/medic/cht-sync/issues/78)
* add versioning and releases ([a528aba](a528aba))
* bind sequence token path to host for persistence ([#88](#88)) ([e1c3953](e1c3953))
* remove superset container and update Readme ([#64](#64)) ([8acbc93](8acbc93))
* update logstash base image version and update default configuration files ([#61](#61)) ([674582d](674582d))
* update postgres version to 16 ([8bf1e84](8bf1e84))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants