Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update base image version and update default configuration files #61

Merged
merged 1 commit into from
Jan 12, 2024
Merged

feat: update base image version and update default configuration files #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion logstash/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM logstash:7.14.1
FROM logstash:8.11.1

COPY ./pipeline /usr/share/logstash/pipeline
COPY ./entrypoint.sh /usr/local/bin/entrypoint.sh
Expand Down
34 changes: 0 additions & 34 deletions logstash/pipeline/couchdb_sentinel.conf
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions logstash/pipeline/couchdb.conf → logstash/pipeline/medic.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
input {
couchdb_changes {
always_reconnect => true
db => "couchdb"
db => "medic"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the purpose of COUCHDB_DBS to define a list of databases you want to sync? Can we use that environment variable here? However, it may only work when it contains one database e.g "medic" and not a list e.g "medic medic_sentinel"

Copy link
Member

@andrablaj andrablaj Jan 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@njuguna-n can you please answer @lorerod's question above? I know you two had some conversations, and capturing the outcome for the public could benefit those who want to know more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is meant to update the default database that logstash listens to. @lorerod your last sentence is true as well, to be able to target multiple databases you need to do that on separate .conf files for example medic_sentinel should have a medic_sentinel.conf file.

host => "${COUCHDB_HOST}"
username => "${COUCHDB_USER}"
password => "${COUCHDB_PASSWORD}"
Expand All @@ -29,6 +29,6 @@ output {
format => "json"
http_method => "post"
ignorable_codes => 409
url => "http://${HTTP_ENDPOINT}/couchdb"
url => "http://${HTTP_ENDPOINT}/medic"
}
}
Loading