Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(#42): Add SonarCloud config #68

Merged
merged 2 commits into from
Feb 9, 2024
Merged

chore(#42): Add SonarCloud config #68

merged 2 commits into from
Feb 9, 2024

Conversation

andrablaj
Copy link
Member

Adds a file containing the repo-level SonarCloud configuration for cht-sync.

See the related documentation.

Closes #42

@andrablaj
Copy link
Member Author

@garethbowen Can you please enable SonarCloud for this repo by following the steps in this documentation. Thanks!

@andrablaj andrablaj self-assigned this Feb 8, 2024
@garethbowen
Copy link
Member

@andrablaj I've done the GH <-> Sonar part. I set the number of days for the new code definition to 1 (which is what we've set it to in cht-core recently).

@garethbowen garethbowen removed their request for review February 9, 2024 09:07
Copy link
Contributor

@njuguna-n njuguna-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor comment. Thanks for adding this.

.sonarcloud.properties Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Feb 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@andrablaj andrablaj merged commit c8f41db into main Feb 9, 2024
5 checks passed
@andrablaj andrablaj deleted the 42-add-sonarcloud branch February 9, 2024 10:14
@garethbowen
Copy link
Member

@jkuester IIRC we turned off the sonarcloud comment (above) in cht-core to reduce spam but I can't remember how we did this and for the life of me I can't find the setting. Can you remember?

@andrablaj
Copy link
Member Author

andrablaj commented Feb 9, 2024

@garethbowen I have just done this by Disabling Summary Content in the Pull Requests (via SonarCloud interface):

Screenshot 2024-02-09 at 10 27 55

@garethbowen
Copy link
Member

😵‍💫 THANK YOU! I must be going blind.

@medic-ci
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SonarCloud configuration
4 participants