Align Makefile - Bundle Creation Update #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: razo7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Operator-sdk v1.26.0 introduced the addition/updation of createdAt field after every make bundle run, and resulting of a change in this field for every new PR.
Only when building the bundle container we set the containerImage and createdAt fields.
razo7
force-pushed
the
bundle-creation-addition
branch
from
e5acb3a
to
5db0927
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the process of moving FAR to Medik8s organization we align the Makefile - fifth PR.
Small changes to bundle creation (similarly to medik8s/node-healthcheck-operator#141, medik8s/self-node-remediation#72, and medik8s/node-maintenance-operator#68 PRs).
make bundle).