Add bundle-cleanup target #103
Conversation
Add bundle-cleanup target to remove the bundle installed via bundle-run Signed-off-by: Carlo Lobrano <[email protected]>
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clobrano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
| @@ -191,6 +191,10 @@ export BUNDLE_RUN_NAMESPACE ?= openshift-operators | |||
| bundle-run: operator-sdk ## Run bundle image. Default NS is "openshift-operators", redefine BUNDLE_RUN_NAMESPACE to override it. | |||
| $(OPERATOR_SDK) -n $(BUNDLE_RUN_NAMESPACE) run bundle $(BUNDLE_IMG) | |||
|
|
|||
| .PHONY: bundle-cleanup | |||
| bundle-cleanup: operator-sdk ## Remove bundle installed via bundle-run | |||
| $(OPERATOR_SDK) -n openshift-operators cleanup $(OPERATOR_NAME) | |||
There was a problem hiding this comment.
NIT: would have been nicer if the namespace would be easily adjustable for cleaning up installation on any namespace.
There was a problem hiding this comment.
This makes sense 👍
Let's also see how it goes the discussion about the new installation namespace
There was a problem hiding this comment.
discussion about the new installation namespace
I think this discussion is about the installation namespace for downstream FAR.
There was a problem hiding this comment.
I think this discussion is about the installation namespace for downstream FAR.
I see, I didn't get this at first. Also, just noticed that bundle-run already is adjustable so I'll change bundle-cleanup accordingly
Add bundle-cleanup target to remove the bundle installed via bundle-run