Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Events for far Remediation Process #107

Merged
merged 8 commits into from
Jan 3, 2024
Merged

Add Events for far Remediation Process #107

merged 8 commits into from
Jan 3, 2024

Commits on Jan 3, 2024

  1. Fetch events API from commons 

    Use Medik8s shared events
    @razo7
    razo7 committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    467480b View commit details
    Browse the repository at this point in the history

  2. Add events to far CR for better visibility of the remediation process 

    The events will help to identify the remediation process by looking on far CR events
    @razo7
    razo7 committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    49bc54b View commit details
    Browse the repository at this point in the history

  3. Add events to unhealthy node for better visibility of the remediation… 

    … process

The events will help to identify the remediation process by looking on node events. Fetch node from IsNodeNameValid, and whether taint was added by AppendTaint
    @razo7
    razo7 committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    5712863 View commit details
    Browse the repository at this point in the history

  4. Only use GetNodeWithName func 

    IsNodeNameValid is no longer needed, as we no longer only need to check CR node validty but we want to receive the node object as well on success
    @razo7
    razo7 committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    d738a52 View commit details
    Browse the repository at this point in the history

  5. Typo fix & CLI errors 

    s/CreateFARRemediationTaint/CreateRemediationTaint. Look for the actual errors, so we can catch a change in the actual errors from the UTs
    @razo7
    razo7 committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    2cb984f View commit details
    Browse the repository at this point in the history

  6. Refactor far unit-test 

    Use human readable timing for timeouts with even better var names. Use verifyPreRemediationSucceed that include checking for finalizer and taint (from event and value). Sleep for a second between unit tests to give dummy reconcilation to run first.
    @razo7
    razo7 committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    a55dc08 View commit details
    Browse the repository at this point in the history

  7. Fix typo 

    s/reconicliation/reconciliation
    @razo7
    razo7 committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    8e72dad View commit details
    Browse the repository at this point in the history

  8. Pass namespace to function 

    Decouple test
    @razo7
    razo7 committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    34ce0ee View commit details
    Browse the repository at this point in the history