Set Suggested Namespace #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The suggested namespace is used to resolve a confusion of installing the operator from console or CLI. On console it uses openshift-operators which is common to other operators, and in CLI docs every operator is installed in its owns namespace
New annotation that will be used in order to make sure 'openshift.io/node-selector' annotation is set on the namespace.
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: razo7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test 4.14-openshift-e2e |
1 similar comment
|
/test 4.14-openshift-e2e |
|
/lgtm |
|
/test 4.14-openshift-e2e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The suggested namespace is used to resolve the confusion of installing the operator from the console vs CLI.
We use two new OCP annotations for this matter and to make sure that
"openshift.io/node-selector":""annotation is set on the installed namespace.Similar to medik8s/self-node-remediation#165, medik8s/self-node-remediation#168, medik8s/node-maintenance-operator#107 and related to ECOPROJECT-1777