Set Replace Annotation #115
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: razo7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test 4.14-openshift-e2e |
Makefile
Outdated
| sed -r -i "s|containerImage: .*|containerImage: $(IMG)|;" ${BUNDLE_CSV} | ||
| sed -r -i "s|createdAt: .*|createdAt: `date '+%Y-%m-%d %T'`|;" ${BUNDLE_CSV} | ||
| sed -r -i "s|replaces: .*|replaces: self-node-remediation.v${PREVIOUS_VERSION}|;" ${BUNDLE_CSV} |
There was a problem hiding this comment.
self-node-remediation looks like a copy paste miss 😉
Even though we use 'skipRange' for defining from which versions we can update to the version of the CSV, we also need to add the 'replace' field. It should point to the last released version, and ensures that the old version isn't deleted from the index.
razo7
force-pushed
the
replace-annotation
branch
from
05bbcf4
to
50208f5
Compare
|
/test 4.14-openshift-e2e |
|
/lgtm In any case I suggest doing couple a simple check (in case you haven't done already) before merging that works as expected. |
|
/retest |
Even though we use 'skipRange' for defining from which versions we can update to the version of the CSV, we also need to add the 'replace' field. It should point to the last released version and ensure that the old version isn't deleted from the index.
docs.engineering.redhat.com/display/CFC/Best_Practices#Best_Practices-SkipRange
Similar to medik8s/self-node-remediation#167, medik8s/node-maintenance-operator#108 and related to ECOPROJECT-1771