Improve Logs from Updating Conditions #117
Conversation
|
Skipping CI for Draft Pull Request. |
|
/test 4.14-openshift-e2e |
1 similar comment
|
/test 4.14-openshift-e2e |
|
/lgtm |
|
/retest |
1 similar comment
|
/retest |
They can but this way we log an error in the function and Reconcile |
Sorry, I meant inside IIUC the additional information this new logs provide is the CR's name, which is already accessible inside |
|
SGTM |
The function has an error when unknown agent has been found. Thus, there is no need to return and check it from reconcile, since it is not an error from trying to update it. FAR can simply log informative error when it was called when unknown ConditionsChangeReason
The time returned from LastUpdateTime was similar to '2024-01-02 15:15:55.737056215 +0000 UTC m=+19.844109800' which is less readable (and more accurate) than '2024-01-02T15:15:55.737056215Z'. The latter is good enough and better human readable IMO
razo7
force-pushed
the
log-err-on-failure
branch
from
3d791ac
to
f520487
Compare
razo7
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clobrano, razo7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
The
UpdateConditionsfunction has an error only when an unknown agent has been found. Thus, there is no need to return and check it from reconcile, since it is not an error from trying to update it.FAR can simply log an informative error when it was called when unknown ConditionsChangeReason.
Moreover, the lastTrinsitionTime print is more human friendly