Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub CI Tests #12

Merged
merged 3 commits into from
Feb 21, 2023
Merged

GitHub CI Tests #12

merged 3 commits into from
Feb 21, 2023

Conversation

razo7
Copy link
Member

@razo7 razo7 commented Feb 16, 2023

  • Add pre-submit, and post-submit jobs.
  • Add test-no-verify target.

@razo7
Copy link
Member Author

razo7 commented Feb 16, 2023

Merge #11 first in order to test the pre-submit job

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@slintes
Copy link
Member

slintes commented Feb 21, 2023

Merge #11 first in order to test the pre-submit job

I think it makes more sense to merge this one first, so the new unit test is actually executed on its PR?

/lgtm
/hold

pre-submit will be checked against PRs and the post-submit will push it to Medik8s Quay
Check for uncommitted changes in code and fail if it needs to
@razo7
Copy link
Member Author

razo7 commented Feb 21, 2023

Merge #11 first in order to test the pre-submit job

I think it makes more sense to merge this one first, so the new unit test is actually executed on its PR?

/lgtm /hold

It does make sense.
/unhold

@slintes
Copy link
Member

slintes commented Feb 21, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 21, 2023
@openshift-merge-robot openshift-merge-robot merged commit dc2029d into medik8s:main Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants