Initialize Event Recorder for executer #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initialization was missing. recorder was nil
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: razo7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test 4.14-openshift-e2e |
|
I think a UT capturing an event would be nice |
Beforehand the event was emitted after every successful status update while running the agent
Setup fake recoder for executer and test FenceAgentSucceeded instead of ResourceDeletion event. Better event checking
|
/test 4.14-openshift-e2e |
mshitrit
reviewed
Jan 7, 2024
mshitrit
reviewed
Jan 7, 2024
Code testing with one events recorder instead of two as in production code to simplify testing logic
|
/test 4.14-openshift-e2e |
|
/lgtm |
|
/test 4.13-openshift-e2e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.recorderwas nil.Fix ECOPROJECT-1816