Automate Communities bundle creation #131
Conversation
Signed-off-by: Carlo Lobrano <[email protected]>
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clobrano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
| .PHONY: bundle-community-rh | ||
| bundle-community-rh: bundle-community ## Generate bundle manifests and metadata customized to Red Hat community release | ||
| echo -e "\n # Annotations for OCP\n com.redhat.openshift.versions: \"v${OCP_VERSION}\"" >> bundle/metadata/annotations.yaml | ||
|
|
There was a problem hiding this comment.
Add $(MAKE) bundle-update at the end as in bundle-community target?
There was a problem hiding this comment.
You are right. I haven't noticed that bundle-community-rh already calls bundle-community...
A makefile target named bundle-community-k8s target is needed by the shared bundle build workflow, however it is the very same as bundle-community target. Signed-off-by: Carlo Lobrano <[email protected]>
Use shared GitHub Action workflow to build the bundle and push it to Medik8s community forks ready to create a PR. This works for both RH/OKD and K8S communities. Signed-off-by: Carlo Lobrano <[email protected]>
clobrano
force-pushed
the
automate-rh-community-bundle-0
branch
from
492af8e
to
0ac0f20
Compare
clobrano
changed the title
|
/unhold PR updated with new workflow and ready for review |
|
/lgtm |
|
@clobrano: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
|
I think we don't need to wait for CI tests, as this change is not tested by any of them, we could just merge it |
ECOPROJECT-1579