-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build container using x.y.z golang version and updating Golang version #133
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: razo7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
b7302f4
to
ef7802f
Compare
/test 4.15-test |
ef7802f
to
dcb1a19
Compare
/test 4.15-test |
dcb1a19
to
509fd4c
Compare
/test 4.15-test |
This new version must be found in the Dockerfile base image, CentOS stream 8, otherwise building the container would fail
509fd4c
to
3973de3
Compare
/test 4.15-test |
/test 4.15-openshift-e2e |
There is a tradeoff for using a patch version (here and eventually aligning it in other places) for Golang builder, and the pros won't overcome the cons. It might be more relevant in the future, but not for now. |
Why we need this PR
Simplify how the Dockerfile fetches the Golang version for building the binary.
Changes made
ci-operator.yaml
file for Golang builder in OCP CI.Which issue(s) this PR fixes
Follow up to #132, and should not be merged beforehand.