Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to multiple templates with the same kind #135

Merged
merged 6 commits into from
Mar 20, 2024

Conversation

mshitrit
Copy link
Member

@mshitrit mshitrit commented Mar 19, 2024

Why we need this PR

This PR will enable the user to select several FAR Templates (of the same kind) when using NHC escalating remediation.
In a nutshell Far can be used several times as a remediator each time with a different fence agent.
This feature is dependent on the changes in NHC as well (which will be available from NHC 0.8.0).

Changes made

  • Added a "Defaulting" (Mutating) Webhook to Far's Template which automaticlly adds to the template the "Support Same Kind" annotation which NHC detects
  • Fetching node name from "Node Name" annotation in case it exist instead of always assuming that the Node's name is the CR's name
  • Upgraded common version in order to use both mentioned annotations from common

Which issue(s) this PR fixes

ECOPROJECT-1918

Test plan

Copy link
Contributor

openshift-ci bot commented Mar 19, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@mshitrit
Copy link
Member Author

/test 4.14-openshift-e2e

@mshitrit mshitrit changed the title [WIP] Add support to multiple templates with the same kind Add support to multiple templates with the same kind Mar 19, 2024
@mshitrit
Copy link
Member Author

/test 4.14-openshift-e2e

@mshitrit
Copy link
Member Author

/test 4.14-openshift-e2e

@mshitrit
Copy link
Member Author

/test 4.14-openshift-e2e

@razo7
Copy link
Member

razo7 commented Mar 20, 2024

/test 4.14-openshift-e2e

I would recommend testing on 4.15. since it is the latest version we have in CI, and it was already released :)
/test 4.15-openshift-e2e

@openshift-ci openshift-ci bot added the lgtm label Mar 20, 2024
Copy link
Contributor

openshift-ci bot commented Mar 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, mshitrit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mshitrit mshitrit marked this pull request as ready for review March 20, 2024 19:01
@openshift-ci openshift-ci bot requested review from beekhof and clobrano March 20, 2024 19:01
@openshift-merge-bot openshift-merge-bot bot merged commit 85b6f24 into medik8s:main Mar 20, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants